dcapwell commented on code in PR #3416:
URL: https://github.com/apache/cassandra/pull/3416#discussion_r1685049657
##########
src/java/org/apache/cassandra/tcm/RemoteProcessor.java:
##########
@@ -200,51 +203,27 @@ public static <REQ, RSP> RSP sendWithCallback(Verb verb,
REQ request, CandidateI
public static <REQ, RSP> void sendWithCallbackAsync(Promise<RSP> promise,
Verb verb, REQ request, CandidateIterator candidates, Retry retryPolicy)
{
- class Request implements RequestCallbackWithFailure<RSP>
Review Comment:
@ifesdjeen if you want I can revert, I tried to make sure the subtle
semantics did match (other than allocation of callback), but figured could have
all 3 usage use 1 thing that has tests rather than all 3 locations doing custom
logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
