dcapwell commented on code in PR #3416:
URL: https://github.com/apache/cassandra/pull/3416#discussion_r1685051757


##########
test/distributed/org/apache/cassandra/distributed/shared/ClusterUtils.java:
##########
@@ -611,8 +632,8 @@ public static void 
waitForCMSToQuiesce(ICluster<IInvokableInstance> cluster, Epo
                 if (cluster.get(j).isShutdown())
                     continue;
                 Epoch version = getClusterMetadataVersion(cluster.get(j));
-                if (!awaitedEpoch.equals(version))
-                    notMatching.add(new ClusterMetadataVersion(j, version, 
getClusterMetadataVersion(cluster.get(j))));
+                if (!awaitedEpoch.equals(version) && version.getEpoch() < 
awaitedEpoch.getEpoch())

Review Comment:
   not sure if this breaks anything on your end, but I found that I would see 
epoch=33 then fail because every node is on epoch=34... so I use this more as a 
min wait barrier than anything else...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to