belliottsmith commented on code in PR #106:
URL: https://github.com/apache/cassandra-accord/pull/106#discussion_r1692249136
##########
accord-core/src/main/java/accord/local/CommandsForKey.java:
##########
@@ -290,6 +302,75 @@ public static InternalStatus get(int ordinal)
}
}
+ static class LoadingPruned extends TxnId
Review Comment:
There is some doc about this, but minimal and not spread widely enough, and
probably not at the class level. I will update that to describe what's going on
here. This is the "once we prune we are left with potentially incomplete
information, and have to sometimes load per-command information from disk" part
of the patch.
Pruned TxnId are those we have decided we probably don't need as we expect
them to be transitive dependencies of transactions we've already applied, but
that could still appear as dependencies again, but also might just be
unwitnessed transactions with an old id - and to know which it is, we have to
load the TxnId to find out what the command-level data knows of it.
That is to say, pruning doesn't trigger this, but encountering a `TxnId`
dependency that occurs before `prunedBefore` does.
##########
accord-core/src/main/java/accord/local/CommandsForKey.java:
##########
@@ -290,6 +302,75 @@ public static InternalStatus get(int ordinal)
}
}
+ static class LoadingPruned extends TxnId
Review Comment:
That is to say, pruning doesn't trigger this, but encountering a `TxnId`
dependency that occurs before `prunedBefore` does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
