belliottsmith commented on code in PR #106:
URL: https://github.com/apache/cassandra-accord/pull/106#discussion_r1692257099
##########
accord-core/src/main/java/accord/local/CommandsForKey.java:
##########
@@ -372,112 +483,208 @@ public String toString()
return "Info{" +
"txnId=" + toPlainString() +
", status=" + status +
- ", executeAt=" + (executeAt == this ? toPlainString() :
executeAt.toString()) +
+ ", executeAt=" + plainExecuteAt() +
'}';
}
public String toPlainString()
{
return super.toString();
}
+
+ public int compareExecuteAt(TxnInfo that)
+ {
+ return this.executeAt.compareTo(that.executeAt);
+ }
+
+ Timestamp executeAtIfKnownElseTxnId()
+ {
+ return status == INVALID_OR_TRUNCATED ? this : executeAt;
+ }
}
- public static class TxnInfoWithMissing extends TxnInfo
+ public static class TxnInfoExtra extends TxnInfo
{
public final TxnId[] missing;
Review Comment:
I would prefer not to make the name any longer. There is a brief comment on
the accessor method that explains what this is, that I will expand and
reference here.
This is also explained in detail in the class level documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
