bdeggleston commented on PR #106: URL: https://github.com/apache/cassandra-accord/pull/106#issuecomment-2263599074
> quick question: what do you think of splitting `CommandsForKey` into its own package? Don't have a strong feeling, but feel like it might have enough ancillary internal classes and complexity that it would aid in comprehension. I wouldn't want to split them all into a higher class in a shared package, however, as it would badly pollute that. So, could introduce accord.local.cfk to contain all of its inner classes and use package-private visibility rather than private where appropriate. +1 to that. It's grown to a point where that's reasonable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
