aweisberg commented on code in PR #101:
URL: https://github.com/apache/cassandra-accord/pull/101#discussion_r1714226376
##########
accord-core/src/main/java/accord/coordinate/Exhausted.java:
##########
@@ -37,4 +39,16 @@ public Exhausted(TxnId txnId, @Nullable RoutingKey homeKey,
String message)
{
super(txnId, homeKey, message);
}
+
+ protected Exhausted(TxnId txnId, @Nullable RoutingKey homeKey, Exhausted
cause)
+ {
+ super(txnId, homeKey, cause);
+ }
+
+ @Override
+ public Exhausted wrap()
+ {
+ checkState(this.getClass() == Exhausted.class);
Review Comment:
How? There is a derived class `RangeUnavailable` that appears to be unused
that could fail to implement `wrap()`?
Making the method `final` wouldn't stop the creation of derived classes
although I could make the classes final. I don't really have a preference I
just didn't want to dictate whether the classes could be extended since we
already had a case of extending them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
