dcapwell commented on code in PR #101:
URL: https://github.com/apache/cassandra-accord/pull/101#discussion_r1664743703
##########
accord-core/src/main/java/accord/local/Bootstrap.java:
##########
@@ -124,8 +125,11 @@ void start(SafeCommandStore safeStore0)
if (!node.topology().hasEpoch(globalSyncId.epoch()))
{
- node.topology().awaitEpoch(globalSyncId.epoch())
- .addCallback(() -> store.execute(empty(),
this::start).begin(node.agent())).begin(node.agent());
+ // Ignore timeouts fetching the epoch, always keep trying to
bootstrap
+ node.withEpoch(globalSyncId.epoch(), (ignored, failure) ->
store.execute(empty(), Attempt.this::start).begin((ignored1, failure2) -> {
Review Comment:
if the epoch timed out why are we trying to start the attempt? If we do we
should fail in weird ways, instead we should keep waiting...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
