blerer commented on code in PR #3444:
URL: https://github.com/apache/cassandra/pull/3444#discussion_r1716861672
##########
pylib/cqlshlib/test/test_cqlsh_completion.py:
##########
@@ -390,14 +390,14 @@ def test_complete_in_update(self):
self.trycompletions("UPDATE empty_table SET lonelycol = 'eggs' WHERE
TOKEN(lonelykey ",
choices=[',', ')'])
self.trycompletions("UPDATE empty_table SET lonelycol = 'eggs' WHERE
TOKEN(lonelykey) ",
- choices=['=', '<=', '>=', '<', '>'])
+ choices=['=', '<=', '>=', '<', '>', '!='])
self.trycompletions("UPDATE empty_table SET lonelycol = 'eggs' WHERE
TOKEN(lonelykey) <= TOKEN(13) ",
choices=[';', 'AND', 'IF'])
self.trycompletions("UPDATE empty_table SET lonelycol = 'eggs' WHERE
TOKEN(lonelykey) <= TOKEN(13) IF ",
choices=['EXISTS', '<quotedName>', '<identifier>'])
self.trycompletions("UPDATE empty_table SET lonelycol = 'eggs' WHERE
TOKEN(lonelykey) <= TOKEN(13) IF EXISTS ",
- choices=['>=', '!=', '<=', 'IN', '[', ';', '=',
'<', '>', '.', 'CONTAINS'])
+ choices=['>=', '!=', '<=', 'IN','[', ';', '=',
'<', '>', '.', 'CONTAINS'])
Review Comment:
I am a bit confused by that one because we should not have those
auto-completion after IF EXISTS.
##########
src/java/org/apache/cassandra/cql3/restrictions/SimpleRestriction.java:
##########
@@ -217,7 +219,11 @@ public boolean isSupportedBy(Index index)
@Override
public List<ClusteringElements> values(QueryOptions options)
{
- assert operator == Operator.EQ || operator == Operator.IN || operator
== Operator.ANN;
+ assert operator == Operator.EQ ||
+ operator == Operator.IN ||
+ operator == Operator.ANN ||
+ operator == Operator.NEQ ||
+ operator == Operator.NOT_IN;
Review Comment:
Why? They are slices operator so this method should not be called for them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
