ekaterinadimitrova2 commented on code in PR #3444:
URL: https://github.com/apache/cassandra/pull/3444#discussion_r1717062111
##########
src/java/org/apache/cassandra/cql3/restrictions/SimpleRestriction.java:
##########
@@ -217,7 +219,11 @@ public boolean isSupportedBy(Index index)
@Override
public List<ClusteringElements> values(QueryOptions options)
{
- assert operator == Operator.EQ || operator == Operator.IN || operator
== Operator.ANN;
+ assert operator == Operator.EQ ||
+ operator == Operator.IN ||
+ operator == Operator.ANN ||
+ operator == Operator.NEQ ||
+ operator == Operator.NOT_IN;
Review Comment:
```
java.lang.AssertionError
at
org.apache.cassandra.cql3.restrictions.SimpleRestriction.values(SimpleRestriction.java:222)
at
org.apache.cassandra.cql3.restrictions.PartitionKeyRestrictions.nonTokenRestrictionValues(PartitionKeyRestrictions.java:197)
at
org.apache.cassandra.cql3.restrictions.PartitionKeyRestrictions.values(PartitionKeyRestrictions.java:118)
at
org.apache.cassandra.cql3.restrictions.StatementRestrictions.getPartitionKeys(StatementRestrictions.java:767)
at
org.apache.cassandra.cql3.statements.SelectStatement.getSliceCommands(SelectStatement.java:714)
at
org.apache.cassandra.cql3.statements.SelectStatement.getQuery(SelectStatement.java:412)
at
org.apache.cassandra.cql3.statements.SelectStatement.getQuery(SelectStatement.java:393)
at
org.apache.cassandra.cql3.statements.SelectStatement.executeInternal(SelectStatement.java:589)
at
org.apache.cassandra.cql3.statements.SelectStatement.executeLocally(SelectStatement.java:574)
at
org.apache.cassandra.cql3.statements.SelectStatement.executeLocally(SelectStatement.java:109)
at
org.apache.cassandra.cql3.QueryProcessor.executeInternal(QueryProcessor.java:478)
at
org.apache.cassandra.cql3.CQLTester.executeFormattedQuery(CQLTester.java:1654)
at org.apache.cassandra.cql3.CQLTester.execute(CQLTester.java:1633)
at
org.apache.cassandra.cql3.CQLTester.assertInvalidThrowMessage(CQLTester.java:2273)
at
org.apache.cassandra.cql3.CQLTester.assertInvalidThrowMessage(CQLTester.java:2252)
at
org.apache.cassandra.cql3.CQLTester.assertInvalidMessage(CQLTester.java:2237)
at
org.apache.cassandra.cql3.validation.operations.SelectSingleColumnRelationTest.testWithUnsetValues(SelectSingleColumnRelationTest.java:623)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at
com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
at
com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
at
com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
at
com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:232)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:55)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
