adelapena commented on code in PR #3444:
URL: https://github.com/apache/cassandra/pull/3444#discussion_r1725633291
##########
pylib/cqlshlib/cql3handling.py:
##########
@@ -738,11 +738,12 @@ def working_on_keyspace(ctxt):
;
<whereClause> ::= <relation> ( "AND" <relation> )*
;
-<relation> ::= [rel_lhs]=<cident> ( "[" <term> "]" )? ( "=" | "<" | ">" | "<="
| ">=" | "CONTAINS" ( "KEY" )? ) <term>
+<relation> ::= [rel_lhs]=<cident> ( "[" <term> "]" )? ( "=" | "<" | ">" | "<="
| ">=" | "CONTAINS" ( "KEY" )? | "NOT CONTAINS" ( "KEY" )? ) <term>
| token="TOKEN" "(" [rel_tokname]=<cident>
( "," [rel_tokname]=<cident> )*
- ")" ("=" | "<" | ">" | "<=" | ">=")
<tokenDefinition>
+ ")" ("=" | "!=" | "<" | ">" | "<=" | ">=")
<tokenDefinition>
| [rel_lhs]=<cident> "IN" "(" <term> ( "," <term> )* ")"
+ | [rel_lhs]=<cident> "NOT IN" "(" <term> ( "," <term> )* ")"
Review Comment:
I don't see that it currently suggests `IN` or `NOT IN` with token:
```
cqlsh> SELECT * FROM k.t WHERE TOKEN(k)
< <= = > >=
```
It's in a different line than `CONTAINS` but not the same line as `TOKEN`,
maybe I'm missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
