ekaterinadimitrova2 commented on code in PR #3444:
URL: https://github.com/apache/cassandra/pull/3444#discussion_r1725450113
##########
pylib/cqlshlib/cql3handling.py:
##########
@@ -738,11 +738,12 @@ def working_on_keyspace(ctxt):
;
<whereClause> ::= <relation> ( "AND" <relation> )*
;
-<relation> ::= [rel_lhs]=<cident> ( "[" <term> "]" )? ( "=" | "<" | ">" | "<="
| ">=" | "CONTAINS" ( "KEY" )? ) <term>
+<relation> ::= [rel_lhs]=<cident> ( "[" <term> "]" )? ( "=" | "<" | ">" | "<="
| ">=" | "CONTAINS" ( "KEY" )? | "NOT CONTAINS" ( "KEY" )? ) <term>
| token="TOKEN" "(" [rel_tokname]=<cident>
( "," [rel_tokname]=<cident> )*
- ")" ("=" | "<" | ">" | "<=" | ">=")
<tokenDefinition>
+ ")" ("=" | "!=" | "<" | ">" | "<=" | ">=")
<tokenDefinition>
| [rel_lhs]=<cident> "IN" "(" <term> ( "," <term> )* ")"
+ | [rel_lhs]=<cident> "NOT IN" "(" <term> ( "," <term> )* ")"
Review Comment:
Actually the way IN was added, it was claiming that token function supports
IN when the goal was to be added to general where clause on top.
I moved the IN/NOT in on top and then we get the same result as for CONTAINS
- no mention of NOT and KEY option, just the operator. If we want to start
adding in auto complete all options, I think this should be separate ticket.
Let's not overcomplicate here. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
