belliottsmith commented on code in PR #113:
URL: https://github.com/apache/cassandra-accord/pull/113#discussion_r1745968102
##########
accord-core/src/main/java/accord/coordinate/Barrier.java:
##########
@@ -230,6 +228,13 @@ private ExistingTransactionCheck
checkForExistingTransaction()
return check;
}
+ private void register(SafeCommandStore safeStoreWithTxn, TxnId txnId,
RoutableKey key)
+ {
+ BarrierCommandListener listener = new BarrierCommandListener();
+ if (listener.notify(safeStoreWithTxn, safeStoreWithTxn.get(txnId,
key.toUnseekable())))
Review Comment:
yes, and that also made me notice a minor issue with registerAndInvoke that
I will address
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
