belliottsmith commented on code in PR #3490:
URL: https://github.com/apache/cassandra/pull/3490#discussion_r1754607184
##########
src/java/org/apache/cassandra/service/accord/serializers/CommandsForKeySerializer.java:
##########
@@ -350,6 +354,8 @@ public static ByteBuffer toBytesWithoutKey(CommandsForKey
cfk)
VIntCoding.writeUnsignedVInt(prevEpoch, out);
VIntCoding.writeUnsignedVInt(prevHlc, out);
+ VIntCoding.writeUnsignedVInt32(cfk.redundantBefore().flags(), out);
Review Comment:
Hmm, looks like the standard serialiser takes up more space. But sure, don't
mind using it - but perhaps we should encode epoch/hlc/flags separately in the
standard serialiser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
