belliottsmith commented on code in PR #3490:
URL: https://github.com/apache/cassandra/pull/3490#discussion_r1754959227
##########
src/java/org/apache/cassandra/service/accord/AccordKeyspace.java:
##########
@@ -623,11 +620,11 @@ public Row withoutRedundantCommands(PartitionKey key, Row
row, RedundantBefore.E
if (current == null)
return null;
- CommandsForKey updated =
current.withRedundantBeforeAtLeast(redundantBefore);
+ CommandsForKey updated =
current.withRedundantBeforeAtLeast(redundantBefore.shardRedundantBefore());
if (current == updated)
return row;
- if (updated.size() == 0)
+ if (updated.size() == 0 && updated.prunedBefore() ==
CommandsForKey.NO_INFO)
Review Comment:
I think in retrospect I don't need the modification anyway, as updated must
be non-empty if prunedBefore != NO_INFO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
