michaelsembwever commented on code in PR #3526:
URL: https://github.com/apache/cassandra/pull/3526#discussion_r1758631053
##########
src/java/org/apache/cassandra/hints/HintVerbHandler.java:
##########
@@ -89,6 +92,20 @@ else if
(!StorageProxy.instance.appliesLocally(hint.mutation))
// the topology has changed, and we are no longer a replica of the
mutation - since we don't know which node(s)
// it has been handed over to, re-address the hint to all
replicas; see CASSANDRA-5902.
HintsService.instance.writeForAllReplicas(hint);
+
+ HintsService.instance.metrics.incrHintsReceivedForUnownedRanges();
+ if (DatabaseDescriptor.getLogOutOfTokenRangeRequests())
+ {
+ // Log at most 1 message per second
+ NoSpamLogger.log(logger,
+ NoSpamLogger.Level.WARN,
+ 1,
+ TimeUnit.SECONDS,
+ "Received hint containing mutation from {}
for token {} outside valid range",
+ message.from(),
+ hint.mutation.key().getToken());
Review Comment:
```suggestion
"Receiving hint not owned or pending,
example: from {} for a partition token {} in {}.{}",
message.from(),
hint.mutation.key().getToken(),
<keyspace>, <cf>);
```
…?
(does NoSpamLogger provide any indication in the logs that this is but a
sample?)
(same suggestion applies to other NoSpamLogger usages)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
