maedhroz commented on code in PR #3526:
URL: https://github.com/apache/cassandra/pull/3526#discussion_r1759193146
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -6077,6 +6118,36 @@ public void
setNativeTransportMaxConcurrentRequestsInBytesPerIp(long newLimit)
ClientResourceLimits.setEndpointLimit(newLimit);
}
+ public boolean isOutOfTokenRangeRequestLoggingEnabled()
+ {
+ return DatabaseDescriptor.getLogOutOfTokenRangeRequests();
+ }
Review Comment:
The first purpose of the method is obviously just to implement
`isOutOfTokenRangeRequestLoggingEnabled()` in `StorageServiceMBean`. Outside
that, in places like `RepairMessageVerbHandler`, it's used in the context of
other `StorageService` calls like `getNormalizedLocalRanges()`, so the original
intent was to treat all this as the responsibility of `StorageService`. Of
course, that would potentially change if this was done w/ the Guardrails
framework, but that's another discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
