dcapwell commented on code in PR #3574:
URL: https://github.com/apache/cassandra/pull/3574#discussion_r1776357617
##########
src/java/org/apache/cassandra/service/accord/fastpath/ParameterizedFastPathStrategy.java:
##########
@@ -64,7 +64,7 @@ static class WeightedDc implements Comparable<WeightedDc>
public void serialize(WeightedDc dc, DataOutputPlus out, Version
version) throws IOException
{
out.writeUTF(dc.name);
- out.writeUnsignedVInt(dc.weight);
+ out.writeUnsignedVInt32(dc.weight);
Review Comment:
by actually trying to serialize this I found this bug... why do we keep
`out.writeUnsignedVInt` around if we don't allow it anymore? 🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
