dcapwell commented on code in PR #3574:
URL: https://github.com/apache/cassandra/pull/3574#discussion_r1777563337
##########
src/java/org/apache/cassandra/tcm/serialization/Version.java:
##########
@@ -36,13 +39,24 @@ public enum Version
/**
* - Added version to PlacementForRange serializer
* - Serialize MemtableParams when serializing TableParams
+ */
+ V2(2),
+
+ /**
* - Added AccordFastPath
+ * - Added ConsensusMigrationState
* - Added AccordStaleReplicas
+ * - TableParam now has pendingDrop (accord table drop is multistep)
*/
- V2(2),
+ V3(3),
Review Comment:
this now conflicts with
https://issues.apache.org/jira/browse/CASSANDRA-19954 on trunk....
Believe Sam/Marcus plan to also add more to V3... so Accord is likely V4,
but with the `MIN_ACCORD_VERSION` it should be easier to handle when that
happens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
