dcapwell commented on code in PR #3416:
URL: https://github.com/apache/cassandra/pull/3416#discussion_r1777757256


##########
src/java/org/apache/cassandra/tcm/Processor.java:
##########
@@ -74,4 +78,20 @@ default ClusterMetadata fetchLogAndWait(Epoch waitFor)
     ClusterMetadata fetchLogAndWait(Epoch waitFor, Retry.Deadline retryPolicy);
 
     LogState reconstruct(Epoch lowEpoch, Epoch highEpoch, Retry.Deadline 
retryPolicy);
+
+    default List<ClusterMetadata> reconstructFull(Epoch lowEpoch, Epoch 
highEpoch)

Review Comment:
   `LogState reconstruct`  was added by @ifesdjeen for this patch (though he 
added in a different ticket) but `LogState` is repetitive to work with in our 
context and we just want the `List<ClusterMetadata>`, so added this here to 
simplify Accord logic



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to