smiklosovic commented on code in PR #3579:
URL: https://github.com/apache/cassandra/pull/3579#discussion_r1778641277
##########
src/java/org/apache/cassandra/auth/AuthenticatedUser.java:
##########
@@ -44,8 +44,8 @@ public class AuthenticatedUser
public static final AuthenticatedUser ANONYMOUS_USER = new
AuthenticatedUser(ANONYMOUS_USERNAME);
// User-level permissions cache.
- public static final PermissionsCache permissionsCache = new
PermissionsCache(DatabaseDescriptor.getAuthorizer());
- public static final NetworkPermissionsCache networkPermissionsCache = new
NetworkPermissionsCache(DatabaseDescriptor.getNetworkAuthorizer());
+ public static PermissionsCache permissionsCache = new
PermissionsCache(DatabaseDescriptor.getAuthorizer());
Review Comment:
I am quite uncomfortable about this. You should at least make it `volatile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
