smiklosovic commented on code in PR #3579:
URL: https://github.com/apache/cassandra/pull/3579#discussion_r1778644759


##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -1457,6 +1461,68 @@ public void setConcurrentCompactors(int value)
         CompactionManager.instance.setConcurrentCompactors(value);
     }
 
+    public String getAuthenticator()
+    {
+        return DatabaseDescriptor.getAuthenticator().getClass().getName();
+    }
+
+    public void setAuthenticator(String value)
+    {
+        if (value == null)
+            throw new IllegalArgumentException("Authenticator cannot be null");
+
+        try {
+            Class<?> cl = Class.forName(value);
+
+            // Ensure the class implements IAuthenticator
+            if (IAuthenticator.class.isAssignableFrom(cl)) {

Review Comment:
   once 19946 is in, this should be done by means of ParameterizedClass and 
related logic around instantiation, this logic is redundant, imho.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to