dcapwell commented on code in PR #103:
URL: https://github.com/apache/cassandra-accord/pull/103#discussion_r1779004231
##########
accord-core/src/main/java/accord/topology/Shard.java:
##########
@@ -116,6 +116,8 @@ public String toString(boolean extendedInfo)
sb.append('f');
}
sb.append(')');
+ if (!joining.isEmpty())
Review Comment:
spoke with @bdeggleston and this is really `non-readable` in Cassandra... so
just a case of bad naming. Right now this is dead code so it doesn't impact
anything, but it is something we should flesh out... we spoke before that we
have an issue with this case as we will try to read from non-readable nodes and
have to fall back... this adds latency to user requests that could be avoided
by leveraging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
