dcapwell commented on code in PR #103:
URL: https://github.com/apache/cassandra-accord/pull/103#discussion_r1777736940
##########
accord-core/src/main/java/accord/primitives/Timestamp.java:
##########
@@ -365,6 +365,11 @@ static <T extends Timestamp> T merge(Timestamp a,
Timestamp b, Constructor<T> co
@Override
public String toString()
+ {
+ return toStandardString();
+ }
+
+ public String toStandardString()
Review Comment:
so, when we serializer in some cases we only know `Timestamp` but we have
many types... and almost all override `toString` so the parser of string to
`Timestamp` breaks... By making this method it makes sure we can always do the
following property
```
new Timestamp(this).equals(Timestamp.parse(this.toStandardString()))
```
##########
accord-core/src/main/java/accord/primitives/Timestamp.java:
##########
@@ -365,6 +365,11 @@ static <T extends Timestamp> T merge(Timestamp a,
Timestamp b, Constructor<T> co
@Override
public String toString()
+ {
+ return toStandardString();
+ }
+
+ public String toStandardString()
Review Comment:
this is not a core change, it was just found in testing....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
