bereng commented on code in PR #3605:
URL: https://github.com/apache/cassandra/pull/3605#discussion_r1808684780
##########
src/java/org/apache/cassandra/cql3/QueryProcessor.java:
##########
@@ -149,6 +149,7 @@ public void preloadPreparedStatements()
clientState.setKeyspace(keyspace);
Prepared prepared = parseAndPrepare(query, clientState, false);
+ prepared.cacheEntrySize = measureCacheEntrySize(id, prepared);
Review Comment:
That's how we calculate the cache size
[here](https://github.com/apache/cassandra/pull/3605/files#diff-3ce9f6c4626262d6a4be26ecf3a57ef11fdb55537448def0c736115417487115R95).
You need to measure both the key and value. Unlucky, otherwise yes it would
have been nice to have the size in the pstmnt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
