smiklosovic commented on code in PR #3605:
URL: https://github.com/apache/cassandra/pull/3605#discussion_r1808431005
##########
src/java/org/apache/cassandra/cql3/QueryProcessor.java:
##########
@@ -149,6 +149,7 @@ public void preloadPreparedStatements()
clientState.setKeyspace(keyspace);
Prepared prepared = parseAndPrepare(query, clientState, false);
+ prepared.cacheEntrySize = measureCacheEntrySize(id, prepared);
Review Comment:
perf tests need to compute it anyway, no? generator stress tool of prepared
statements? never heard of that, is that a thing? Otherwise I think that
measuring the size of it is rather innocent operation. If somebody ever
complains (I really doubt that) we can always go back. We still need at least
one compelling reason why not to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
