dcapwell commented on code in PR #3624:
URL: https://github.com/apache/cassandra/pull/3624#discussion_r1811085781
##########
src/java/org/apache/cassandra/tcm/RemoteProcessor.java:
##########
@@ -152,15 +152,21 @@ public ClusterMetadata fetchLogAndWait(Epoch waitFor,
Retry.Deadline retryPolicy
}
@Override
- public LogState reconstruct(Epoch lowEpoch, Epoch highEpoch,
Retry.Deadline retryPolicy)
+ public LogState getLocalState(Epoch start, Epoch end, boolean
includeSnapshot, Retry.Deadline retryPolicy)
+ {
+ return log.getLocalEntries(start, end, includeSnapshot);
+ }
+
+ @Override
+ public LogState getLogState(Epoch lowEpoch, Epoch highEpoch, boolean
includeSnapshot, Retry.Deadline retryPolicy)
Review Comment:
why does the retry policy only reflect the `request.get` timeout and isn't
used for the networking retries? all the attempt logic is ignored and just the
upper limit is leveraged, so we don't have `retry` respected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
