belliottsmith commented on code in PR #3624:
URL: https://github.com/apache/cassandra/pull/3624#discussion_r1811125853
##########
src/java/org/apache/cassandra/service/accord/AccordSafeCommandStore.java:
##########
@@ -305,6 +305,7 @@ public void setSafeToRead(NavigableMap<Timestamp, Ranges>
newSafeToRead)
@Override
public void setRangesForEpoch(CommandStores.RangesForEpoch rangesForEpoch)
{
+ super.setRangesForEpoch(rangesForEpoch);
Review Comment:
I don't think this is correct? We shouldn't set this until we have written
it to the journal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
