aweisberg commented on code in PR #3631:
URL: https://github.com/apache/cassandra/pull/3631#discussion_r1813398562
##########
src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java:
##########
@@ -514,6 +518,10 @@ public CQLStatement prepare(ClientState state)
checkNotNull(select.parameters.refName, "Assignments must be
named");
TxnDataName name = TxnDataName.user(select.parameters.refName);
checkTrue(selectNames.add(name), DUPLICATE_TUPLE_NAME_MESSAGE,
name.name());
+ if (select.parameters.orderings != null &&
!select.parameters.orderings.isEmpty())
Review Comment:
Seems like maybe a bit of copy pasta forbidding things between `LET` selects
and returning selects? Maybe the common forbidden things could be moved into a
single shared method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
