aweisberg commented on code in PR #3631:
URL: https://github.com/apache/cassandra/pull/3631#discussion_r1815275420
##########
src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java:
##########
@@ -98,9 +98,13 @@ public class TransactionStatement implements
CQLStatement.CompositeCQLStatement,
public static final String INCOMPLETE_PRIMARY_KEY_SELECT_MESSAGE = "SELECT
must specify either all primary key elements or all partition key elements and
LIMIT 1. In both cases partition key elements must be always specified with
equality operators; %s %s";
public static final String NO_CONDITIONS_IN_UPDATES_MESSAGE = "Updates
within transactions may not specify their own conditions; %s statement %s";
public static final String NO_TIMESTAMPS_IN_UPDATES_MESSAGE = "Updates
within transactions may not specify custom timestamps; %s statement %s";
+ public static final String NO_TTLS_IN_UPDATES_MESSAGE = "Updates within
transactions may not specify custom ttls; %s statement %s";
public static final String TRANSACTIONS_DISABLED_ON_TABLE_MESSAGE =
"Accord transactions are disabled on table (See transactional_mode in table
options); %s statement %s";
public static final String
TRANSACTIONS_DISABLED_ON_TABLE_BEING_DROPPED_MESSAGE = "Accord transactions are
disabled on table (table is being dropped); %s statement %s";
public static final String NO_COUNTERS_IN_TXNS_MESSAGE = "Counter columns
cannot be accessed within a transaction; %s statement %s";
+ public static final String NO_AGGREGATION_IN_TXNS_MESSAGE = "No
aggregation functions allowed within a transaction; %s statement %s";
+ public static final String NO_ORDER_BY_IN_TXNS_MESSAGE = "No ORDER BY
clause allowed within a transaction; %s statement %s";
Review Comment:
We discussed this offline. There isn't really adequate testing of `ORDER BY`
and while it does look like `ORDER BY` on the clustering key works any `ORDER
BY` that requires post execution ordering or a `LIMIT` isn't handled correctly.
It's fine to block it until we get things sorted out better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
