beobal commented on code in PR #3637:
URL: https://github.com/apache/cassandra/pull/3637#discussion_r1818878189
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -430,6 +430,12 @@ public static class SSTableConfig
public DurationSpec.IntMillisecondsBound dynamic_snitch_reset_interval =
new DurationSpec.IntMillisecondsBound("10m");
public double dynamic_snitch_badness_threshold = 1.0;
+ public String node_proximity;
+ public String initial_location_provider;
+ public String addresses_config;
+ // TODO should this be true by default? may be a change in behaviour for
anything other than EC2MRSnitch
Review Comment:
I think the issue with doing that it makes the deprecation cycle a bit weird
because we're marking `IEndpointSnitch` as deprecated while at the same time
requiring maintainers to update their implementations.
Making them non-default is stricter/more safe and I don't know how effective
a NEWS.txt item alone would be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
