krummas commented on code in PR #3637:
URL: https://github.com/apache/cassandra/pull/3637#discussion_r1867763531
##########
src/java/org/apache/cassandra/locator/GoogleCloudLocationProvider.java:
##########
@@ -30,6 +30,7 @@ public class GoogleCloudLocationProvider extends
CloudMetadataLocationProvider
{
static final String DEFAULT_METADATA_SERVICE_URL =
"http://metadata.google.internal";;
static final String ZONE_NAME_QUERY_URL =
"/computeMetadata/v1/instance/zone";
+ static final ImmutableMap HEADERS = ImmutableMap.of("Metadata-Flavor",
"Google");
Review Comment:
`<String, String>`
##########
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##########
@@ -781,21 +782,29 @@ private ServerEncryptionOptions applyConfigInternal()
public boolean shouldEncrypt(InetAddressAndPort endpoint)
{
- IEndpointSnitch snitch = DatabaseDescriptor.getEndpointSnitch();
+ // TODO this is a bit inaccurate - reword it
Review Comment:
this todo probably needs fixing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
