jaydeepkumar1984 commented on code in PR #3367:
URL: https://github.com/apache/cassandra/pull/3367#discussion_r1828310099


##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -346,6 +346,17 @@ public enum CassandraRelevantProperties
      */
     
GOSSIP_SETTLE_POLL_SUCCESSES_REQUIRED("cassandra.gossip_settle_poll_success_required",
 "3"),
 
+    /**
+     * If set to true, mutations streamed during anti-entropy repair will be 
replayed via the regular write path for associated views.
+     */
+    
STREAMING_REQUIRES_VIEW_BUILD_DURING_REPAIR("cassandra.streaming.requires_view_build_during_repair",
 "true"),

Review Comment:
   Ok, I have made the following two changes:
   1. Backported https://issues.apache.org/jira/browse/CASSANDRA-17666
   2. Implemented a similar flag to 
https://issues.apache.org/jira/browse/CASSANDRA-17666 for MV
   
   tl;dr - I've removed these properties instead it is now controlled by two 
yaml flags
   
   ```
   cdc_on_repair_enabled: false
   materialized_views_on_repair_enabled: false
   ```
   
   The above two flags are `true` by default, so one needs to disable them. The 
changes have been pushed to the same PR; please take a look at it.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to