dcapwell commented on code in PR #3656:
URL: https://github.com/apache/cassandra/pull/3656#discussion_r1830071784
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -1222,15 +1264,27 @@ public void tryMarkRemoved(Topology topology, Id target)
if (node.commandStores().count() == 0) return; // when starting up
stores can be empty, so ignore
Ranges ranges = topology.rangesForNode(target);
if (ranges.isEmpty()) return;
- tryMarkRemoved(ranges, 0).begin(node().agent());
+ long startNanos = Clock.Global.nanoTime();
+ exclusiveSyncPointWithRetries(ranges, 0)
Review Comment:
its always been async, I just renamed it as I was supposed to add the
durability message in, but since that was asked to remove I removed the
`.flatMap` to send the message.
The logic has always been fire-and-forget and best-effort... durability
scheduling is supposed to do the right thing but it takes time to do that, if
you did another host replacement before it could do that we get into a bad
state...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
