dcapwell commented on code in PR #3656:
URL: https://github.com/apache/cassandra/pull/3656#discussion_r1828458026


##########
test/harry/main/org/apache/cassandra/harry/sut/injvm/InJvmSutBase.java:
##########
@@ -182,17 +196,21 @@ else if (StringUtils.startsWithIgnoreCase(statement, 
"SELECT"))
             }
             catch (Throwable t)
             {
-                if (retryStrategy.apply(t))
+                onException(t);
+                if (attempt < maxRetries && retryStrategy.apply(t))
                     continue;
-
-                logger.error(String.format("Caught error while trying execute 
statement %s (%s): %s",
-                                           statement, 
Arrays.toString(bindings), t.getMessage()),
-                             t);
+                attempt++;
+                logger.error("Caught error while trying execute statement {} 
({})", statement, Arrays.toString(bindings), t);
                 throw t;
             }
         }
     }
 
+    protected void onException(Throwable t)

Review Comment:
   the `AccordSut` tries to log debug information about the failed txn



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to