dcapwell commented on code in PR #3656:
URL: https://github.com/apache/cassandra/pull/3656#discussion_r1830255400
##########
test/unit/org/apache/cassandra/service/accord/AccordStateCacheTest.java:
##########
@@ -428,7 +428,7 @@ public void evictionBlockedOnSaving()
instance.release(item);
}
- assertCacheState(cache, 0, 4, nodeSize(1) * 3 + nodeSize(3));
Review Comment:
these tests have been failing for so long... finally got around to them.
the string is `0*` which is size 2... not 3...
##########
test/unit/org/apache/cassandra/service/accord/AccordStateCacheTest.java:
##########
@@ -464,7 +464,7 @@ public void testUpdates()
safeString.set("11");
instance.release(safeString);
- assertCacheState(cache, 0, 1, nodeSize(3));
+ assertCacheState(cache, 0, 1, nodeSize(2));
Review Comment:
the string is `11` so size 2, not 3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
