dcapwell commented on code in PR #3656:
URL: https://github.com/apache/cassandra/pull/3656#discussion_r1831425133
##########
src/java/org/apache/cassandra/tcm/PaxosBackedProcessor.java:
##########
@@ -176,7 +176,23 @@ public LogState getLocalState(Epoch start, Epoch end,
boolean includeSnapshot)
@Override
public LogState getLogState(Epoch start, Epoch end, boolean
includeSnapshot, Retry.Deadline retryPolicy)
{
- return DistributedMetadataLogKeyspace.getLogState(start, end,
includeSnapshot);
+ while (!retryPolicy.reachedMax())
+ {
+ if (Thread.currentThread().isInterrupted())
+ {
+ Thread.currentThread().interrupt();
Review Comment:
in this case I don't need to re-interrupt... I called `isInterrupted` and
not `interrupted`. One thing I find annoying with this pattern is I always
need to relook at the implementation details to write proper, so some times I
get lazy and just re-interrupt rather than look at the details...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
