rtib commented on code in PR #3661:
URL: https://github.com/apache/cassandra/pull/3661#discussion_r1832491984
##########
src/java/org/apache/cassandra/gms/Gossiper.java:
##########
@@ -1991,15 +1991,10 @@ public List<String> reloadSeeds()
logger.trace("Triggering reload of seed node list");
// Get the new set in the same that buildSeedsList does
Review Comment:
This comment is not actually true now. Better would be: `// Get configured
seeds list.`
##########
src/java/org/apache/cassandra/gms/Gossiper.java:
##########
@@ -2027,6 +2022,10 @@ public List<String> reloadSeeds()
seeds.addAll(tmp);
// Remove the old entries
seeds.retainAll(tmp);
+
+ if (tmp.contains(getBroadcastAddressAndPort()))
+ seeds.remove(getBroadcastAddressAndPort());
Review Comment:
I'm not completely sure about this. Why add all first and remove the own
entry afterwards? Wouldn't it be better to remove the own entry from tmp just
before adding all to seeds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
