dcapwell commented on code in PR #3661:
URL: https://github.com/apache/cassandra/pull/3661#discussion_r1833140753
##########
src/java/org/apache/cassandra/gms/Gossiper.java:
##########
@@ -1986,20 +1986,15 @@ void buildSeedsList()
/**
* JMX interface for triggering an update of the seed node list.
*/
- public List<String> reloadSeeds()
+ public synchronized List<String> reloadSeeds()
Review Comment:
why `synchronized`? We don't do that when touching the `seeds` object so
are you just trying to block concurrent nodetool commands? I am cool with
that, but to be 100% clear this does not fix the race condition bug with this
method mutating `seeds`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
