dcapwell commented on code in PR #3662:
URL: https://github.com/apache/cassandra/pull/3662#discussion_r1834860276
##########
src/java/org/apache/cassandra/schema/SchemaConstants.java:
##########
@@ -62,7 +62,7 @@ public final class SchemaConstants
/* virtual table system keyspace names */
public static final Set<String> VIRTUAL_SYSTEM_KEYSPACE_NAMES =
- ImmutableSet.of(VIRTUAL_VIEWS, VIRTUAL_SCHEMA);
+ ImmutableSet.of(VIRTUAL_SCHEMA, VIRTUAL_VIEWS, VIRTUAL_METRICS,
VIRTUAL_ACCORD_DEBUG);
Review Comment:
so, one line of thinking is how this all works with downgrades. We
*require* 5.0 to be able to downgrade to 4.1... the main area that this breaks
is when we make schema changes... for the accord keyspace we don't do anything
fancy but the pattern of delaying till you opt in does help for downgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
