maedhroz commented on code in PR #3702:
URL: https://github.com/apache/cassandra/pull/3702#discussion_r1851272446


##########
src/java/org/apache/cassandra/index/sai/utils/IndexTermType.java:
##########
@@ -667,16 +672,31 @@ else if (!indexType.subTypes().isEmpty() && 
!indexType.isMultiCell())
             capabilities.add(Capability.VECTOR);
 
         if (indexType instanceof InetAddressType)
+        {
             capabilities.add(Capability.INET_ADDRESS);
+            reversed = false;
+        }
 
         if (indexType instanceof IntegerType)
+        {
             capabilities.add(Capability.BIG_INTEGER);
+            reversed = false;
+        }
 
         if (indexType instanceof DecimalType)
+        {
             capabilities.add(Capability.BIG_DECIMAL);
+            reversed = false;
+        }
 
         if (indexType instanceof LongType)
+        {
             capabilities.add(Capability.LONG);
+            reversed = false;
+        }
+
+        if (reversed)
+            capabilities.add(Capability.REVERSED);

Review Comment:
   These will now have `isReversed()` return `false` during `Expression` 
creation to align w/ the fact we don't actually index reversed byte-comparables 
for these types.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to