dcapwell commented on code in PR #3702:
URL: https://github.com/apache/cassandra/pull/3702#discussion_r1852968601
##########
src/java/org/apache/cassandra/index/sai/utils/IndexTermType.java:
##########
@@ -491,7 +497,9 @@ public int comparePostFilter(Expression.Value
requestedValue, Expression.Value c
{
if (isInetAddress())
return compareInet(requestedValue.encoded, columnValue.encoded);
- // Override comparisons for frozen collections and composite types
(map entries)
+ else if (isLong() || isBigDecimal() || isBigInteger())
+ return indexType.unwrap().compare(requestedValue.raw,
columnValue.raw);
+ // Override comparisons for frozen collections and composite types
(map entries)
else if (isComposite() || isFrozen())
return FastByteOperations.compareUnsigned(requestedValue.raw,
columnValue.raw);
Review Comment:
took a bit for my brain to process, and you dumping in slack... data on disk
is backwards due to `ReverseType` reversing the bytes, so we need to live with
this behavior which is a pain... :sigh:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
