belliottsmith commented on code in PR #144:
URL: https://github.com/apache/cassandra-accord/pull/144#discussion_r1860804421
##########
accord-core/src/test/java/accord/impl/basic/Cluster.java:
##########
@@ -778,7 +780,7 @@ private static void
verifyConsistentRestore(Int2ObjectHashMap<NavigableMap<TxnId
if (!store.unsafeCommands().containsKey(txnId))
{
Command beforeCommand = before.get(txnId);
- if (beforeCommand.saveStatus() == SaveStatus.Erased)
Review Comment:
Should we permit this? I don't think we should even *have* any commands
where `saveStatus` is `Uninitialised` - might indicate some other problem? If
the command is `Uninitialised` it means we didn't touch it, so we shouldn't
have saved it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
