belliottsmith commented on code in PR #144:
URL: https://github.com/apache/cassandra-accord/pull/144#discussion_r1860812078
##########
accord-core/src/test/java/accord/impl/mock/MockConfigurationService.java:
##########
@@ -18,27 +18,27 @@
package accord.impl.mock;
+import accord.api.ConfigurationService;
import accord.api.MessageSink;
import accord.api.TestableConfigurationService;
import accord.local.Node;
import accord.primitives.Ranges;
import accord.topology.Topology;
import accord.utils.EpochFunction;
+import accord.utils.Invariants;
import accord.utils.async.AsyncChains;
import accord.utils.async.AsyncResult;
import accord.utils.async.AsyncResults;
-import org.junit.jupiter.api.Assertions;
-
import java.util.*;
public class MockConfigurationService implements TestableConfigurationService
{
private final MessageSink messageSink;
private final List<Topology> epochs = new ArrayList<>();
- private final Map<Long, EpochReady> acks = new HashMap<>();
+ private final Map<Long, ConfigurationService.EpochReady> acks = new
HashMap<>();
Review Comment:
static import class?
##########
accord-core/src/test/java/accord/impl/mock/MockConfigurationService.java:
##########
@@ -18,27 +18,27 @@
package accord.impl.mock;
+import accord.api.ConfigurationService;
import accord.api.MessageSink;
import accord.api.TestableConfigurationService;
import accord.local.Node;
import accord.primitives.Ranges;
import accord.topology.Topology;
import accord.utils.EpochFunction;
+import accord.utils.Invariants;
import accord.utils.async.AsyncChains;
import accord.utils.async.AsyncResult;
import accord.utils.async.AsyncResults;
-import org.junit.jupiter.api.Assertions;
-
import java.util.*;
public class MockConfigurationService implements TestableConfigurationService
{
private final MessageSink messageSink;
private final List<Topology> epochs = new ArrayList<>();
- private final Map<Long, EpochReady> acks = new HashMap<>();
+ private final Map<Long, ConfigurationService.EpochReady> acks = new
HashMap<>();
private final List<AsyncResult<Void>> syncs = new ArrayList<>();
- private final List<Listener> listeners = new ArrayList<>();
+ private final List<ConfigurationService.Listener> listeners = new
ArrayList<>();
Review Comment:
static import class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
