skoppu22 commented on code in PR #152:
URL: https://github.com/apache/cassandra-sidecar/pull/152#discussion_r1869934230
##########
server/src/main/java/org/apache/cassandra/sidecar/routes/AbstractHandler.java:
##########
@@ -331,4 +334,34 @@ public static String extractHostAddressWithoutPort(String
address)
}
return address;
}
+
+ protected StorageOperations getStorageOperations(String host)
+ {
+ CassandraAdapterDelegate delegate =
this.metadataFetcher.delegate(host);
+ StorageOperations storageOperations = delegate == null ? null :
delegate.storageOperations();
+ if (storageOperations == null)
+ {
+ throw cassandraServiceUnavailable();
+ }
+
+
+ return storageOperations;
+ }
+
+ protected <V> void updateJmxMetric(AsyncResult<V> result,
+ JmxOperationsMetrics
jmxOperationsMetrics,
+ String operationName,
+ long startTime)
+ {
+ if (result.succeeded())
+ {
+ jmxOperationsMetrics.recordTimeTaken(operationName + "Succeeded",
Review Comment:
I remember doing the same in C* as well, creating metric name on the fly
based on the status, something like operationSucceeded or operationFailed and
publishing the time which also gives us the failure count indirectly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
