skoppu22 commented on code in PR #152:
URL: https://github.com/apache/cassandra-sidecar/pull/152#discussion_r1878451017
##########
client-common/src/main/java/org/apache/cassandra/sidecar/common/ApiEndpointsV1.java:
##########
@@ -118,6 +118,11 @@ public final class ApiEndpointsV1
public static final String CONNECTED_CLIENT_STATS_ROUTE = API_V1 +
CASSANDRA + "/stats/connected-clients";
+ // Endpoint to retrieve sstable's preemptiveOpenInterval value.
+ // Value returned is in MB, may return negative value when disabled
+ private static final String SSTABLE = "/sstable";
+ public static final String SSTABLE_PREEMPTIVE_OPEN_INTERVAL_ROUTE = API_V1
+ CASSANDRA + SSTABLE +
Review Comment:
I did explore this a little, I believe the one you suggested
/preemptive-open-interval?unit=mb is more easy way to implement and also is
in-line with current JMX call semantics. Other alternatives unnecessarily
complicates conversions from human readable format to byte size at the client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
