frankgh commented on code in PR #160:
URL: https://github.com/apache/cassandra-sidecar/pull/160#discussion_r1883058085
##########
adapters/base/src/main/java/org/apache/cassandra/sidecar/adapters/base/CassandraStorageOperations.java:
##########
@@ -210,7 +207,12 @@ public void outOfRangeDataCleanup(@NotNull String
keyspace, @NotNull String tabl
{
requireNonNull(keyspace, "keyspace must be non-null");
requireNonNull(table, "table must be non-null");
- jmxClient.proxy(StorageJmxOperations.class, STORAGE_SERVICE_OBJ_NAME)
- .forceKeyspaceCleanup(concurrency, keyspace, table);
+ initializeStorageOps().forceKeyspaceCleanup(concurrency, keyspace,
table);
+ }
+
+ protected StorageJmxOperations initializeStorageOps()
+ {
+ return new
GossipDependentStorageJmxOperations(jmxClient.proxy(StorageJmxOperations.class,
Review Comment:
I think you are right these probably don't need gossip enabled, also it's an
unrelated change so I will revert it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
