frankgh commented on code in PR #160:
URL: https://github.com/apache/cassandra-sidecar/pull/160#discussion_r1884641214
##########
server/src/main/java/org/apache/cassandra/sidecar/db/schema/SidecarInternalKeyspace.java:
##########
@@ -33,20 +33,19 @@
* {@link org.apache.cassandra.sidecar.db.RestoreJob} table and {@link
org.apache.cassandra.sidecar.db.RestoreSlice}
* table
*/
-@Singleton
public class SidecarInternalKeyspace extends AbstractSchema
{
private final SchemaKeyspaceConfiguration keyspaceConfig;
private final boolean isEnabled;
- private final Set<TableSchema> tableSchemas = new HashSet<>();
+ private final Set<TableSchema> tableSchemas =
ConcurrentHashMap.newKeySet();
Review Comment:
I think this is a class-internal detail, but I'd prefer to keep it as Set
for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
