belliottsmith commented on code in PR #150:
URL: https://github.com/apache/cassandra-accord/pull/150#discussion_r1885057142
##########
accord-core/src/main/java/accord/local/CommandStore.java:
##########
@@ -479,11 +479,12 @@ final Supplier<EpochReady> bootstrapper(Node node, Ranges
newRanges, long epoch)
Bootstrap bootstrap = new Bootstrap(node, this, epoch,
newRanges);
bootstraps.add(bootstrap);
bootstrap.start(safeStore);
- return new EpochReady(epoch, null, bootstrap.coordination,
bootstrap.data, bootstrap.reads);
+ return new EpochReady(epoch, null, null, bootstrap.data,
bootstrap.reads);
Review Comment:
We expect coordination to be ready much earlier than reads, to restore our
quorum properties as quickly as possible in the event of a topology change.
Being able to serve reads does not actually guarantee we can safely serve
coordination requests anyway, as some of the read results come from a snapshot
and do not have associated transaction information for computed dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
