belliottsmith commented on code in PR #150:
URL: https://github.com/apache/cassandra-accord/pull/150#discussion_r1885073178
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -91,7 +102,7 @@ private Commands()
{
}
- public enum AcceptOutcome { Success, Redundant, RejectedBallot, Truncated }
+ public enum AcceptOutcome { Success, Redundant, RejectedBallot, Retired,
Truncated }
Review Comment:
It's used to refine the handling of the state machine for command stores
that no longer own a range. This helps more clearly support a change that
ensures prompt forward progress (it would happen eventually, but might be
delayed without this change). I will add a comment explaining the rationale.
This is primarily used in PreAccept to skip certain PreAccept steps that might
not work if the command has been erased due to the range being retired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
