lukasz-antoniak commented on code in PR #1998:
URL:
https://github.com/apache/cassandra-java-driver/pull/1998#discussion_r1903957698
##########
guava-shaded/pom.xml:
##########
@@ -46,12 +46,8 @@
<artifactId>error_prone_annotations</artifactId>
</exclusion>
<exclusion>
- <groupId>com.google.j2objc</groupId>
- <artifactId>j2objc-annotations</artifactId>
- </exclusion>
- <exclusion>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>animal-sniffer-annotations</artifactId>
+ <groupId>com.google.guava</groupId>
+ <artifactId>listenablefuture</artifactId>
Review Comment:
Based on [this Guava issue](https://github.com/google/guava/issues/7129), I
guess that sequence of actions was the following:
1. Old Guava version contained `ListenableFuture` interface.
2. At some point Guava team decided to split parts of Guava into other
libraries.
3. Later, it was decided to move the `ListenableFuture` interface back to
Guava.
4. To prevent issues with dependency resolution, on some build systems,
`com.google.guava:listenablefuture` was assigned a high version number and
empty JAR, so that the `com.google.guava:listenablefuture:1.0` is not picked up
(which included colliding `ListenableFuture` interface definition).
I wanted to exclude it, because was thinking that driver users will not need
to download extra JAR. However, since it is our shaded Guava version, it has no
impact to driver users. I am OK removing this exclusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
